adding bucket name support #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this change on my own infrastructure. It works! |
|
This feature is really helpfull can we expect it merged soon ? |
|
is there anything this needs to move forward? |
cloudlena
force-pushed
the
main
branch
2 times, most recently
from
dc0c22d to
412bba1
Compare
|
We need this feature to use s3manager in our environment |
cloudlena
force-pushed
the
main
branch
2 times, most recently
from
2c2b2db to
c73c37e
Compare
Owner
|
Sorry for the long wait, @mstfe! I didn't have too much time to work on s3manager but am back at it now. Would you mind resolving the conflicts? Then I will merge the PR as quickly as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.